Hi Prasanta, Changes are working fine. Before pushing please make sure that in test case we have maximum 80 characters per line.
Thanks, Jay -----Original Message----- From: Philip Race Sent: Wednesday, August 24, 2016 10:21 PM To: Prasanta Sadhukhan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154218: Non-usage of owner Frame when Frame object is passed to getPrintJob() +1 Some day we should still consider an API that lets the application pass in an owner. -phil. On 8/24/16, 3:39 AM, Prasanta Sadhukhan wrote: > Hi All, > > Please review a fix for an issue where it is seen that the Frame > object passed to Toolkit.getPrintJob() is not used when cross platform > print dialog is created, so the print dialog does not have an owner > Frame and therefore if the parent frame is disposed, the print dialog > is not affected. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8154218 > webrev: http://cr.openjdk.java.net/~psadhukhan/8154218/webrev.00/ > > Proposed fix is to get the DialogOwner attribute which has been set > in PrintJob2D.printDialog() and use the returned frame object as owner. > As of now, null is explicitly passed as owner argument. > > Regards > Prasanta
