Re: [OpenJDK 2D-Dev] [9] RFR JDK-8166685: We should unpin stream and pixel buffer in case of setjmp during writeImage in JPEG.

[Philip Race]

+1

-phil.

On 9/26/16, 12:35 AM, Jayathirth D V wrote:

Hi,

Please review the following fix in JDK9 at your convenience:

Bug : https://bugs.openjdk.java.net/browse/JDK-8166685

Webrev : http://cr.openjdk.java.net/~jdv/8166685/webrev.00/ <http://cr.openjdk.java.net/%7Ejdv/8166685/webrev.00/>

Issue : As part of fix for JDK- 8162461 we removed RELEASE_ARRAYS() in writeImage() call in imageioJPEG.c for setjmp case.

Root cause : We can perform non-local jump to setjmp from longjmp during anytime in write process. If there is no RELEASE_ARRAYS() call then it might crash JVM as it was happening in JDK- 8162461.

Solution : We should have RELEASE_ARRAYS() call in setjmp case for writeImage() in imageioJPEG.c.

Thanks,

Jay