ok
+1

On 21.10.16 23:11, Brian Burkhalter wrote:
Barring objections to the contrary I am inclined to go with webrev.00.
There is no precedent in the public javax.imageio.plugins classes for
making getters and the like final. Note also that BMPImageWriteParam,
JPEGImageReadParam, and JPEGImageWriteParam and not final either.

Thanks,

Brian

On Oct 18, 2016, at 2:24 PM, Brian Burkhalter
<brian.burkhal...@oracle.com <mailto:brian.burkhal...@oracle.com>> wrote:

One could potentially change all the public getters in non-final
classes in javax.imageio.plugins.tiff to be final as in

http://cr.openjdk.java.net/~bpb/8165981/webrev.01/

or go even further and additionally refactor TIFFDirectory to be an
interface implemented by the internal TIFFIFD class. In the interest
of mitigating to an extent the difficulty encountered by any users
potentially migrating from the original JAI Image I/O Tools package, I
would however be more in favor of keeping the original proposal in
this thread

http://cr.openjdk.java.net/~bpb/8165981/webrev.00/

wherein only TIFFField and TIFFImageReadParam are made final.



--
Best regards, Sergey.

Reply via email to