I am not sure that it is useful to add a bugid when the test is moved or
some tags are updated or some small bugs fixed in the test.
The @bug tag contains a bugid for which it was written or an bugid which
was found by this test later.
It can contain the bugid of bugfix in the test if the fix will rewrite
the test completely or add some new steps to check(But it likely will be
an RFE)
On 21/02/2018 07:49, Prasanta Sadhukhan wrote:
looks ok. Only thing is the tests do not have the current bugid appended.
Regards
Prasanta
On 2/21/2018 9:15 PM, Sergey Bylokhov wrote:
Hi, Prasanta.
I have updated the tests mentioned in your previous email:
http://cr.openjdk.java.net/~serb/8198333/webrev.10
/java/awt/font/TextLayout/TestAATMorxFont.java should be for mac only
if (!osName.startsWith("mac")) {
42 return;
43 }
I am not sure it has mac specific code, I'll reevaluate this test in
JDK-8198406.
javax/print/PrintServiceLookup/CountPrintServices.java for linux only
if (!os.equals("linux")) {
44 System.out.println("Linux specific test. No need to
continue");
45 return;
46 }
I guess this one could be run on mac as well, but it should be double
checked.
Both tests have headful or printer keywords and already excluded in
the headless mode, which is subject of the fix.
Regards
Prasanta
On 2/21/2018 7:28 PM, Prasanta Sadhukhan wrote:
Couple of points.
Shouldn't java/awt/List/SetBackgroundTest/SetBackgroundTest.java be
run only on solaris/linux as it tests
if (!isXAWT){
77 System.out.println(" this is XAWT-only test. ");
78 return;
79 }
java/awt/Toolkit/RealSync/Test.java has
System.exit(1);
Should we not remove that as it might hamper jtreg run?
I also think that this bugid needs to be added to all updated tests.
Regards
Prasanta
On 2/21/2018 1:33 AM, Phil Race wrote:
+1
-phil
On 02/20/2018 07:10 AM, Sergey Bylokhov wrote:
Hello.
Please review update of the tests for jdk11.
The goal is to make our testing as stable as possible and exclude
any unstable tests(I have started from the tests which may be run
in the headless mode).
Bug: https://bugs.openjdk.java.net/browse/JDK-8198333
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8198333/webrev.09
- The ProblemList.txt is update, I have created a list of new
bugs for any tests which fail at least once in a few iterations on
a different systems.
- "@key headful" was added to some tests which are noop in
headless mode, they have some checks like:
* Desktop.isDesktopSupported
* Toolkit.getDefaultToolkit().getClass().getName().equals/
* GraphicsEnvironment.isHeadlessInstance()
* SystemTray.isSupported()
... etc. These checks are always false in headless mode.
- "@key printer" was added to the tests which works in the
headless mode, and tries to print something. Some of these tests
are noop w/o printer.
- "@run main/othervm" was added to a few tests which fails in
agentvm mode. This mode is a default in mach5.
- A few typos in the tests tags were fixed.
--
Best regards, Sergey.
