Hi Prahalad, I ran all the test cases after change in my Windows 7 intel i5 machine. All the test cases pass, also it looks like we have changes in 3 manual test cases.
1) java/awt/image/VolatileImage/CustomCompositeTest.java didn't fail in my machine, may be some specific configuration leads to failure in your test runs. 2) java/awt/image/VolatileImage/GradientPaints.java resulted in AWT_Assertion failure once among many runs and this may be specifically because I tested on debug build. There is no need to add this test case for windows-all in ProblemList because of AWT_Assetion failure in debug build. Changes are fine. Thanks, Jay -----Original Message----- From: Prahalad Kumar Narayanan Sent: Thursday, March 01, 2018 7:54 AM To: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8198613] Test cases result in failure or timeout when run with OpenGL backend Hello Everyone Good day to you. I missed to share few details while requesting for review: . The removal of VM option -Dsun.java2d.opengl=True implies that the test cases will now execute with the default pipeline for the platform on which the test is run. . Two new test failures have been noticed with this change. . The test cases are listed below and will be added to ProblemList soon (as a batch). . java/awt/image/VolatileImage/CustomCompositeTest.java (failed with exception on win, linux) . java/awt/image/VolatileImage/GradientPaints.java (timeout with xrender) Thank you for your time in review Have a good day Prahalad N. -----Original Message----- From: Prahalad Kumar Narayanan Sent: Wednesday, February 28, 2018 3:00 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [11] RFR: [JDK-8198613] Test cases result in failure or timeout when run with OpenGL backend Hello Everyone Good day to you. Request your time in reviewing a minor fix for the bug . Bug: https://bugs.openjdk.java.net/browse/JDK-8198613 . Title: Test cases result in failure or timeout when run with OpenGL backend Root Cause: . OpenGL is not the default backend (or) the pipeline of choice for Java on different platforms. . However, we have been running many test cases enabling OpenGL with VM option -Dsun.java2d.opengl=True, on all the platforms which results in failures or time outs on many occasions. Information on the Fix: . Kindly refer to the mail thread capturing review suggestions for a similar bug- JDK-8196451 . Discussion Link: http://mail.openjdk.java.net/pipermail/2d-dev/2018-February/008932.html . To stabilize our test suite, we need not enable OpenGL pipeline where OS+OpenGL isn't the supported configuration. . If required, OpenGL pipeline could be enabled by using -vmoptions:"-Dsun.java2d.opengl=True" with Jtreg command. . As a follow-up from the discussion, I've now removed the VM option -Dsun.java2d.opengl=True for the test cases. . In addition, the test cases that were dedicated for OpenGL backend (in open/test/jdk/sun/java2d/OpenGL) have been moved to appropriate directories namely- open/test/jdk/java/awt/image/VolatileImage (or) open/test/jdk/java/awt/Graphics2D. Information on Testing: . The modified test cases have been tested on: Win-10, Win-10 (with hidpi), Win-7, Linux Ubuntu-16.04, Mac Sierra 10.12 platforms. . Based on the test results, ProblemList.txt has been updated and has been captured as a part of this webrev. Kindly review the changes at your convenience and provide your feedback Link: http://cr.openjdk.java.net/~pnarayanan/8198613/webrev.00/ Thank you for your time in review Have a good day Prahalad N.