Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

[Phil Race]

+1 from me ..

-phil.

On 04/17/2018 02:27 AM, Prahalad Kumar Narayanan wrote:

Hello Jay

Changes are good.

Thanks

Have a good day

Prahalad N.

*From:*Jayathirth D V
*Sent:* Tuesday, April 17, 2018 2:23 PM
*To:* Prahalad Kumar Narayanan; Philip Race; 2d-dev

*Subject:* RE: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hi Prahalad,

Thanks for the review.

I have updated the test case to dispose the image reader.

Please find updated webrev:

http://cr.openjdk.java.net/~jdv/6574555/webrev.02/ <http://cr.openjdk.java.net/%7Ejdv/6574555/webrev.02/>

Regards,

Jay

*From:*Prahalad Kumar Narayanan
*Sent:* Tuesday, April 17, 2018 11:50 AM
*To:* Jayathirth D V; Philip Race; 2d-dev

*Subject:* RE: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hello Jay

The changes are fine.

Just a minor observation: The image reader should be disposed in the test case.

Thank you

Have a good day

Prahalad N.

*From:*Jayathirth D V
*Sent:* Friday, April 13, 2018 2:24 PM
*To:* Philip Race; 2d-dev

*Subject:* Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hi Phil,

Thanks for your inputs.

I have modified the test case to use ByteArrayOutput/InputStream.

Please find updated webrev for review:

http://cr.openjdk.java.net/~jdv/6574555/webrev.01/ <http://cr.openjdk.java.net/%7Ejdv/6574555/webrev.01/>

Regards,

Jay

*From:*Phil Race
*Sent:* Wednesday, April 11, 2018 10:40 PM
*To:* Jayathirth D V; 2d-dev

*Subject:* Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

The fix seems fine but like the other review I wonder if
the test can use a bytearrayoutputstream instead of writing to a file.

-phil.

On 04/11/2018 03:51 AM, Jayathirth D V wrote:

    Hello All,

    Please review the following fix in JDK11 :

    Bug : https://bugs.openjdk.java.net/browse/JDK-6574555

    Webrev : http://cr.openjdk.java.net/~jdv/6574555/webrev.00/
    <http://cr.openjdk.java.net/%7Ejdv/6574555/webrev.00/>

    _Issue:_ PNGImageWriter. write_bKGD() function sets incorrect R,
    G, B value when IHDR colortype and bKGD colortype is PNG_COLOR_RGB(A).

    _Solution:_ Assign values to all channels of RGB as they are
    present in Metadata instead of using only bKGD red value.

    _Note_ : Our default metadata doesn’t set any bKGD chunk but if
    user specifies bKGD chunk and uses mergeTree() then we check bKGD
     R, G, B values and if r == g == b then we store bKGD chunk as of
    type PNG_COLOR_GRAY.

    Thanks,

    Jay