Hi Prasanta,

 

Changes are fine.

 

Thanks,

Jay

 

From: Prasanta Sadhukhan 
Sent: Thursday, October 11, 2018 1:40 PM
To: 2d-dev
Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8212040: Compilation error due to wrong 
usage of NSPrintJobDispositionValue in mac10.12

 

Hi All,

Please review a build issue fix for usage of NSPrintJobDispositionValue in 
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8211055"JDK-8211055: 
Provide print to a file (PDF) feature even when printer was not connected
It seems that NSPrintJobDispositionValue is added in 10.13 sdk 
[https://developer.apple.com/documentation/appkit/nsprintjobdispositionvalue?language=objc]
so using it in 10.12 or lower cause build issue.

Fix is to check for disposition value directly instead of storing in variable.
mach5 build is successful.

Bug:https://bugs.openjdk.java.net/browse/JDK-8212040
webrev: http://cr.openjdk.java.net/~psadhukhan/8212040/webrev/

Regards
Prasanta

Reply via email to