Sorry, I'm a little late to the game, but this change broke the AIX build. It also misses a configure check for Xrandr which now became a build dependency.
I've opened "8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it" and sent around a RFR on this [1] list for the trivial fix. Would be nice if you could have a look at it and review it. Thank you and best regards, Volker [1] http://mail.openjdk.java.net/pipermail/2d-dev/2018-November/009636.html On Wed, Oct 31, 2018 at 8:18 PM Phil Race <[email protected]> wrote: > > Erik has an updated devkit that is a pre-requisite for that. It is already > pushed and I tested with his patch which will make the new devkit the > default. > > So mach5 is green once Erik pushes his devkit fix which I have tested > to make sure we always have the header files on otherwise "minimally" > configured linux build systems. > > Ergo, this will go in only once he has pushed his fix : > https://bugs.openjdk.java.net/browse/JDK-8210837 > > -phil. > > On 10/31/18 12:02 PM, Sergey Bylokhov wrote: > > Looks fine, I assume mach5 is green. > > > > On 31/10/2018 11:57, Phil Race wrote: > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8210863 > >> Webrev: http://cr.openjdk.java.net/~prr/8210863/ > >> > >> JDK imported Xrandr headers into it's source a really long time ago > >> because > >> old build systems did not have it. We no longer have that problem, so > >> we can > >> remove these. > >> > >> I am not changing the code to remove the dynamic loading of the > >> functions and > >> change it to compile time link against them. > >> We can probably do that too at a later time, but the immediate goal > >> is to > >> remove these source files since they are imported 3rd party sources. > >> > >> -phil. > >> > >> > > > > >
