Thanks Jay, Prasanta, I've obviously verified the fix with J9 and SwingSet2 demo, and all looks good. Cheers Andrew
Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Jayathirth Rao <jayathirth....@oracle.com> To: Andrew Leonard <andrew_m_leon...@uk.ibm.com> Cc: 2d-dev@openjdk.java.net Date: 27/03/2019 12:59 Subject: Re: [OpenJDK 2D-Dev] Request for Sponsor: 8217735: awt_image_GifImageDecoder_parseImage() "interlace" param has the wrong type Hi Andrew, Thanks for your contribution. I would be happy to sponsor this change. May be J9 by default has tighter checks for JNI parameter types or -XCheck:jni option(https://www.eclipse.org/openj9/docs/xcheck/) is enabled while running Swingset demo. I think if we enable non-standard option -XCheck:jni in hotspot( https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html#BABHDABI ) we might see similar issue. I think there is no need for regression test for this case and I will just add a label in bug. Change looks good to me. Thanks, Jay On 27-Mar-2019, at 5:00 PM, Andrew Leonard <andrew_m_leon...@uk.ibm.com> wrote: Thanks Prasanta, moving to 2d-dev maillist... Hi, Please can I obtain a sponsor for this simple fix to correct the parseImage() jni parameter type? https://bugs.openjdk.java.net/browse/JDK-8217735 http://cr.openjdk.java.net/~aleonard/8217735/webrev.00/ The problem manifests itself most notably with OpenJ9 when running the SwingSet2 demo, depending on how the stack byte alignment resolves iteself. I've not seen an issue yet running SwingSet2 with Hotspot, possibly by luck of stack alignment. Many thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Prasanta Sadhukhan <prasanta.sadhuk...@oracle.com> To: Andrew Leonard <andrew_m_leon...@uk.ibm.com>, awt-...@openjdk.java.net Date: 27/03/2019 09:57 Subject: Re: <AWT Dev> Request for Sponsor: 8217735: awt_image_GifImageDecoder_parseImage() "interlace" param has the wrong type I can sponsor this...But I guess this review should be going to 2d-dev instead of awt-dev. Regards Prasanta On 27-Mar-19 1:12 AM, Andrew Leonard wrote: Hi, Please can I obtain a sponsor for this simple fix to correct the parseImage() jni parameter type? https://bugs.openjdk.java.net/browse/JDK-8217735 http://cr.openjdk.java.net/~aleonard/8217735/webrev.00/ The problem manifests itself most notably with OpenJ9 when running the SwingSet2 demo, depending on how the stack byte alignment resolves iteself. I've not seen an issue yet running SwingSet2 with Hotspot, possibly by luck of stack alignment. Many thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
