OK. +1 from me.
-phil
On 11/11/19, 10:27 PM, Prasanta Sadhukhan wrote:
On 12-Nov-19 11:20 AM, Philip Race wrote:
It can't hurt can it ?
And a while (a good while) back an AWT developer claimed it was also
recommended for AWT ... I can't find that claim - too hard to locate.
So whilst we don't need to rush off and update all pure AWT tests we
also don't
need to create more technical debt.
OK. Tried without EDT change and mach5 is still green for 3 iterations
on all 3 platforms .
http://cr.openjdk.java.net/~psadhukhan/8233910/webrev.1/
Regards
Prasanta
-phil.
On 11/11/19, 9:14 PM, Prasanta Sadhukhan wrote:
I felt it was not needed as it is awt test and it is not necessary
to call under EDT, unlike swing.
Regards
Prasanta
On 12-Nov-19 1:06 AM, Philip Race wrote:
Hi,
I don't understand why you make this change :-
- SwingUtilities.invokeAndWait(() -> createAndShowGUI());
+ createAndShowGUI();
-phil.
On 11/11/19, 3:14 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a testfix for an issue seen to be failing
intermittently in mach5 nightly linux system.
The test uses robot to pick color from a frame's midpoint and
check if the alpha is blended properly with the color but it seems
the color is picked from wrong point.
Proposed fix is to make the fraae undecorated and also call
setLocationRelativeTo() to show the frame at the middle away from
taskbar to avoid possible mis-pick of color.
mach5 job is run on all 3 platforms and link is present in JBS.
Bug: https://bugs.openjdk.java.net/browse/JDK-8233910
webrev: http://cr.openjdk.java.net/~psadhukhan/8233910/webrev.0/
Regards
Prasanta
