Hi Clemens, Thanks for the patch, the fix looks good to me. I'm not a reviewer however so I can't approve the push...
Cheers, Mario On Thu, Jan 9, 2020 at 9:51 AM Clemens Eisserer <linuxhi...@gmail.com> wrote: > > Hi, > > Please review the fix for bug 8235904 "Infinite loop when rendering > huge lines": http://cr.openjdk.java.net/~ceisserer/8235904/webrev.01/ > > The issue was caused by integer overflow during clipping: While the > original native code used int or long depending on the coordinate > range, the java-port unconditionally always used ints - which led to > the issue. > The code was ported to java back then to avoid JNI overhead. > > A big thanks to Mario Torre for analyzing the issue in detail and > bringing it to my attention. > > Thanks, Clemens > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https://www.redhat.com> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
