Hi Sergey, Prasanta, Pankaj, Thank you for the review. May I ask a sponsor of the fix as well? I'm not a committer.
Best Regards, Toshio Nakamura Pankaj Bansal <pankaj.b.ban...@oracle.com> wrote on 2020/03/05 18:22:43: > From: Pankaj Bansal <pankaj.b.ban...@oracle.com> > To: Toshio 5 Nakamura <toshi...@jp.ibm.com>, awt- > d...@openjdk.java.net, 2d-dev <2d-dev@openjdk.java.net> > Date: 2020/03/05 18:22 > Subject: [EXTERNAL] RE: <AWT Dev> RFR: 8240518: Incorrect > JNU_ReleaseStringPlatformChars in Windows Print > > Looks good to me > > -Pankaj > > -----Original Message----- > From: Sergey Bylokhov > Sent: Thursday, March 5, 2020 2:35 PM > To: Toshio 5 Nakamura <toshi...@jp.ibm.com>; awt- > d...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net> > Subject: Re: <AWT Dev> RFR: 8240518: Incorrect > JNU_ReleaseStringPlatformChars in Windows Print > > (CC) 2d-dev, > > Looks fine. > > On 3/4/20 4:48 am, Toshio 5 Nakamura wrote: > > Hi, > > > > I'd like to ask review and sponsor of this fix. > > > > Issue: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8240518&d=DwIFAg&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=Ugr81mDyW3UBisxHYIBGJRn59YtU54N94eZ3qym_AxI&s=aiMA0Y77aGl1__RhHjtvahZ0wWG8fG0G4BgFOcpvrPY&e= > > Fix: https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8240518_webrev.00&d=DwIFAg&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=Ugr81mDyW3UBisxHYIBGJRn59YtU54N94eZ3qym_AxI&s=YaighmfLyolNRz8ORpStjqHH1p4KX8d4g_AwsY0GPHk&e= > > > > Eclipse OpenJ9 VM detects two errors about > JNU_ReleaseStringPlatformChars in WPrinterJob.cpp. > > Then, I checked similar situation in the folder, and found one > lacking of the release method in awt_PrintControl.cpp. > > > > Best regards, > > > > Toshio Nakamura > > > > > -- > Best regards, Sergey. >