Hi Sergey,

I guess it is better if you directly pass NULL to OpenPrinter, rather than create an unnecessary variable.

Also, I think it will be good if we do a ClosePrinter() if FindFirstPrinterChangeNotification() fails.

Regards
Prasanta
On 30-Mar-20 7:13 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk/client.

Bug: https://bugs.openjdk.java.net/browse/JDK-8241829
Fix: http://cr.openjdk.java.net/~serb/8241829/webrev.00

In PrintServiceLookupProvider.java we always pass NULL to
the notifyFirstPrinterChange as a name of the printer, so
we can remove the code which expects a non-null value.

Reply via email to