Looks good to me.

Thanks,
Jay

> On 06-Jul-2020, at 12:43 PM, Baesken, Matthias <matthias.baes...@sap.com> 
> wrote:
> 
> Hello, please review this small change to font related logging .
>  
> We have a lot of font logging calls in java.desktop that look similar to this 
> coding :
> 
>         if (FontUtilities.isLogging()) {
>             FontUtilities.getLogger().info("Here comes my important info");
>         }
> 
> This coding could be simplified by adding static log methods to 
> FontUtilities.java  
>  
> public static void logWarning(String s);
> public static void logInfo(String s);
> public static void logSevere(String s);
>  
>   doing the isLogging check + FontUtilities.getLogger(). …
>  
>  
>  
> Bug/webrev :
>  
> https://bugs.openjdk.java.net/browse/JDK-8248802 
> <https://bugs.openjdk.java.net/browse/JDK-8248802>
>  
> http://cr.openjdk.java.net/~mbaesken/webrevs/8248802.0/ 
> <http://cr.openjdk.java.net/~mbaesken/webrevs/8248802.0/>
>  
>  
> Thanks, Matthias

Reply via email to