One isn't strictly required, but the code in the file isn't used.

The other (hb-coretext.cc) needs to be excluded on other platforms besides macOS.

I think the build must actually strip the directory part and just look for
the filename part, else the build should have failed with the wrong path.

-phil.

On 8/11/20, 2:38 AM, Magnus Ihse Bursie wrote:


On 2020-08-10 22:47, Philip Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8251367
webrev: http://cr.openjdk.java.net/~prr/8251367/

When using something other than the java launcher (ie the jpackage launcher)
harfbuzz.dll is not found by windows dll loading.
So we need to load it explicitly else the Java class that loads fontmanager,dll
will fail to initialize.

At the same time, I'd like to fix a very minor inconsequential pair of typoes
that exclude from the build files by the wrong directory pathname.
Phil,

Is the exclude still needed, if the build worked fine without it..?

/Magnus

-phil.

Reply via email to