On Fri, 18 Sep 2020 23:01:57 GMT, Phil Race <p...@openjdk.org> wrote:
>> Hello All, >> >> Could you please review a TEST_BUG fix for the JDK 16? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8248352 >> >> Problem description: The test >> test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially >> leave the >> frame open if it fails. If it were not for the frame, the test could be >> headless. So probably, we can remove the call >> to showText() from the test and make it headless.. Fix: An argument is >> added to the test. If "-show" is passed, the >> test will show UI for visual inspection. > > Marked as reviewed by prr (Reviewer). Since you remove the @headful keyword, did you check that the test works fine via mach5? It will now select a completely different set of test systems. ------------- PR: https://git.openjdk.java.net/jdk/pull/255