> On Sep 29, 2020, at 4:05 PM, Lutz Schmidt <l...@openjdk.java.net> wrote: > > On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee <p...@openjdk.org> wrote: > >>> Please review this small patch to enable the OSX build using Xcode 12.0. >>> >>> Thanks, >>> Paul >> >> Paul Hohensee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains three additional commits since >> the last revision: >> - 8253375: Reverted CSystemColors.m patch, replaced sharedRuntime.cpp patch >> - Merge branch 'master' into JDK-8253375 >> - JDK-8253375 > > The proposed (updated) change does _NOT_ compile on my machine (MacOS > 10.15.6, Xcode 12.0): > > sharedRuntime.cpp:2860:46: error: cannot cast from type 'struct (anonymous > struct at sharedRuntime.cpp:2859:7)' to > pointer type 'relocInfo *’
Did you use the change from the PR, or apply it manually. That looks like the error one would get if only the type of locs_buf were changed, without changing to take the address in the reference. That is, without changing `(relocInfo*)locs_buf` to `(relocInfo*)&locs_buf`. That second change is in the PR. > You will have to use a union (option (2) as proposed by Kim Barrett far > above. I proved that variant compiles on my > machine. > > ------------- > > Changes requested by lucy (Reviewer). > > PR: https://git.openjdk.java.net/jdk/pull/348
