On Tue, 12 Jan 2021 18:40:39 GMT, Phil Race <[email protected]> wrote:
>> Laurent Bourgès has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - fixed copyright year
>> - removed invalid jtreg test
>
> src/java.desktop/share/classes/sun/java2d/pipe/SpanShapeRenderer.java line 45:
>
>> 43: */
>> 44: public abstract class SpanShapeRenderer implements ShapeDrawPipe {
>> 45:
>
> I suppose this is just clean up when you happened to notice it wasn't used/
Exactly.
> test/jdk/sun/java2d/marlin/StrokedLinePerf.java line 37:
>
>> 35: * @bug 7018932
>> 36: * @summary fix LoopPipe.getStrokedSpans() performance (clipping enabled
>> by Marlin renderer)
>> 37: * @run main/othervm/timeout=10
>> -Dsun.java2d.renderer=sun.java2d.marlin.MarlinRenderingEngine StrokedLinePerf
>
> I hope 10 seconds is enough for a stable test .. not connecting to the
> windowing system so maybe.
Each render ops take up to 100ms max on my machine, so the test runs in 0.5s on
my machine.
Would you prefer 30s ?
Timeout is mandatory to detect test failure = hanging ...
-------------
PR: https://git.openjdk.java.net/jdk/pull/2013
