On Wed, 17 Feb 2021 17:34:22 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> This test was timing out in windows in mach5 nightly testing. Investigation >> reveals that 70% of the time, it is failing due to printer being chosen was >> Microsoft Print to PDF which opens up a File Save Dialog when "OK" was >> clicked in printer pagedialog. Since no user intervention is done to dismiss >> the modal filedialog, so subsequent pagedialog was not dismissed resulting >> in timeout. >> Other times, it was found that "One Note" software printer was used as >> default printerservice which again, opens up a OneNote app which again gets >> focus and obscure pagedialog so PageDialog did not get dismissed. >> Updated test to ignore "Print To PDF", "OneNote" and "XPS Document >> Writer"(which again opens filedialog like PDF printer) and run it for >> several iteration in mach5 platforms which is ok. Link in JBS. > > Shouldn't you update copyright years in the header of the test? No, it's not mandatory to update the copyright year as there is script that should update it at end of release. ------------- PR: https://git.openjdk.java.net/jdk/pull/2598
