On Thu, 11 Mar 2021 04:24:26 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Nothing throws an exception or otherwise prevent this being negative but >> that would be a weird usage. Typically the weight is either zero or based on >> the font size .. which ought not to be negative but I don't think anything >> prevents it and I think we would treat it essentially as a transform. So If >> you really want to be careful here, then yes assume weight could be negative. > > By that same logic, then shouldn't absorbweight also be checked as != 0 > instead of > 0 as that also uses += gi.weight Hi, I am not sure about the absorbweight check; but currently the calculated value weightedAbsorb is only used when absorbing is true. And there the > 0 check is present too boolean absorbing = hitLimit && absorbweight > 0; ------------- PR: https://git.openjdk.java.net/jdk/pull/2912
