On Wed, 31 Mar 2021 15:03:54 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state >> information because of which we ignore clip parameters set in rect clip and >> shape clip. We need to query and use encoders from EncoderManager to honour >> clip states in copyArea. > > Jayathirth D V has updated the pull request incrementally with one additional > commit since the last revision: > > Add comment on usage of MTLRenderCommandEncoder src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m line 821: > 819: * performing copyArea, thats why we need to query encoder > with > 820: * appropriate state from EncoderManager and not use > 821: * direct MTLBlitCommandEncoder for texture mapping. Minor : "texture mapping" should be "texture copy" as MTLBlitCommandEncoder cannot be used for texture mapping anyway. ------------- PR: https://git.openjdk.java.net/jdk/pull/3283
