On Thu, 6 May 2021 06:58:16 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS >> issue. >> >> I fixed the issue in the harfbuzz sources, but I am not sure of the policy >> here. Do we modify the harfbuzz sources or leave them untouched? Advice is >> welcome. >> >> The patch fixes linux x64 fastdebug and opt build for me. > > Thomas Stuefe has updated the pull request incrementally with one additional > commit since the last revision: > > switch off warning in build instead of fixing it The policy is to do what you ended up doing. We (almost) never modify 3rd party sources in such cases. About the only case is if a fix has already been pushed upstream then we might copy that fix. You did the right thing notifying upstream but still best to just disable this warning for now. ------------- PR: https://git.openjdk.java.net/jdk/pull/3873
