On Tue, 3 Aug 2021 23:42:55 GMT, Sergey Bylokhov <[email protected]> wrote:
>> This is a request to clean up a desktop module as was done in JDK-8233884
>> for "java.base" module.
>>
>> In many places standard charsets are looked up via their names, for example:
>> absolutePath.getBytes("UTF-8");
>>
>> This could be done more efficiently(x20 time faster) with use of
>> java.nio.charset.StandardCharsets:
>> absolutePath.getBytes(StandardCharsets.UTF_8);
>>
>> The later variant also makes the code cleaner, as it is known not to throw
>> UnsupportedEncodingException in contrary to the former variant.
>>
>> Tested by the desktop headless/headful tests on linux/windows.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update IPPPrintService.java
I admit I prefer static imports in this case: the code is shorter and is as
clear. It's pretty obvious where the encoding comes from.
-------------
Marked as reviewed by aivanov (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4951
