On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote: > On 02/12/2017 03:51 PM, Noriko Hosoi wrote: > > > > https://pagure.io/389-ds-base/issue/49121 > > > > https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch > > > > These odd » characters are shown at some part of the patch. I wonder > > what causes this display issue... And non-ascii characters are not > > printed correctly although they are in the "View Raw" mode. Please > > see the utf8str.txt file. > > > > 277 @@ -1499,30 +1506,36 @@ entry2str_internal_size_attrlist( const > > Slapi_Attr *attrlist, int entry2str_ctrl > > 280 » » /* Count the space required for the present and > > deleted values */ > > 281 -» » elen+= entry2str_internal_size_valueset(a->a_type, > > &a->a_present_values, > > 282 -» » » » » » » » » » » » entry2str_ctrl, attribute_state, > > 283 -» » » » » » » » » » » » VALUE_PRESENT); 305 +» » elen += > > entry2str_internal_size_valueset(a, a->a_type, > > &a->a_present_values, > > 306 +» » entry2str_ctrl, attribute_state, VALUE_PRESENT); > > > > > > Note: The test build was blessed by the bug reporter. > > Thanks to William for his reviews. I've update the patch based on his > suggestion. > > I also have 2 lib389 patches (attached to this email). Is lib389 still > in fedorahosted? I cloned pagure.io/lib389.git, but I found it empty... > > 1) could you please review the patches?
I'm happy with the dbscan change I don't use the valgrind wrapper myself (it should disable transparently when ASAN is enabled). I'm not sure about the check for sbin dir though, because it shouldn't matter what we use. Is there a reason you need to check for root with just those dirs? Is it related to where the DS instance is from (prefix build vs rpm) > 2) if they look fine, is it ok to push them to fedorahosted git repository? I would ask Mark this, he knows the most about the situation. -- Sincerely, William Brown Software Engineer Red Hat, Brisbane
signature.asc
Description: This is a digitally signed message part
_______________________________________________ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
