> > on 64-bit machines, the unions in the ureg.h can lead to internal > > padding. > > although one tactic not yet implemented, but soon ..., is to make > struct and union alignment match the least alignment required, as is > done for arrays, the approach on amd64 and arm64 is simply not to > bother with the unions. if it's sp, it's sp. link is link. i think > the need for the alias has gone. there aren't any references in port, > which i think might have caused the aliasing in the first place, and > xyz/trap.c should know what's what.
good point. i hadn't considered that it might simply be unnecessary. perhaps because i was also fretting about this not being done consistently across various codebases. do you think that's perhaps worth leaving the #define in as a temporary measure? - erik
