[ 
https://issues.apache.org/jira/browse/ABDERA-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566272#action_12566272
 ] 

Remy Gendron commented on ABDERA-104:
-------------------------------------

This would simplify the code as getId() needs to verify if the server is 
running in the servlet root context to prevent building an IRI with a 
double-slash.

My logic, which may be invalid (please tell me) to build the feed id is:

request.getBaseUri() + Constants.FEED_BASE_PATH + Constants.SOMEFEED;

Thus, with a ctx of / and a base path of /feed/, I get a feed id like 
http://localhost:9002//feed/somefeed

The problem came into light when I stopped deploying in a specific ctx and 
deployed into root because of ABDERA-101.

Thanks.

> Do not call AbstractCollectionAdapter.getId() in createFeedBase() if using 
> default RouteManager.
> ------------------------------------------------------------------------------------------------
>
>                 Key: ABDERA-104
>                 URL: https://issues.apache.org/jira/browse/ABDERA-104
>             Project: Abdera
>          Issue Type: New Feature
>    Affects Versions: 0.3.0
>            Reporter: Remy Gendron
>            Priority: Minor
>
> As the feed IRI is fixed based on the provider base and collection href, this 
> information should be automatically generated.
> This way, configuration information would not need to be maintained in 
> multiple places.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to