[ 
https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615016#action_12615016
 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

I've tried to fix the diff file, but it requires too much manual modifications, 
which I think are error-prone.
I think it's better to apply the diff as it is, skipping not found files, and 
then manually copy the following files from the V2 zip file:

src/test/resources/atomResponse.xml
src/main/java/org/apache/abdera/ext/opensearch/model/Query.java
src/main/java/org/apache/abdera/ext/opensearch/model/IntegerElement.java
src/main/java/org/apache/abdera/ext/opensearch/model/OpenSearchExtensionFactory.java

And finally delete:

src/main/java/org/apache/abdera/ext/opensearch/Query.java
src/main/java/org/apache/abdera/ext/opensearch/IntegerElement.java
src/main/java/org/apache/abdera/ext/opensearch/OpenSearchExtensionFactory.java

What do you think?

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, 
> opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current 
> Open Search extension and providing a new implementation with the following 
> features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search 
> Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model 
> (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package 
> org.apache.abdera.ext.opensearch.server).
> * Two new target types (package 
> org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search 
> description document and the Open Search urls (package 
> org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related 
> tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to