-1 tabs. I've never seen people stick exclusively to tabs. If you don't, then you can't change your tab settings from whatever other people or using, or some parts of the code doesn't look right. I'm in favor of adopting the Hadoop standards as they're fairly widespread and cover most of the code I look at and write :)
-Joey On Fri, Oct 14, 2011 at 2:29 PM, John W Vines <[email protected]> wrote: > +1 tabs - as long as we are consistent, which we will be, then there will be > no issues with needing specific settings for it to look correct. Let the user > control how their page looks by letting them set tab size instead of forcing > them to use a specific space count. > > ----- Original Message ----- > From: "Esteban Gutierrez" <[email protected]> > To: [email protected] > Sent: Thursday, October 13, 2011 4:39:33 PM > Subject: Re: Indentation style? > > +1 for two-spaces > -1 for tabs > > esteban > > > On Thu, Oct 13, 2011 at 1:36 PM, Adam Fuchs <[email protected]> wrote: > >> +1 for consistent formatting. >> +1 for tabs. >> -1 for spaces. >> >> Tabs are nice because everyone can choose their own look and feel (i.e. I >> don't have to look at 2-space indenting!). >> >> Adam >> >> >> On Wed, Oct 12, 2011 at 9:46 PM, Drew Farris <[email protected]> wrote: >> >> > Hi All, >> > >> > I'm wondering if there's consensus on the indentation style for Accumulo? >> > >> > In the code and poms, I'm seeing cases where tabs are used, where >> > spaces are used, where each is used interchangeably, sometimes mixed >> > in the same file. This makes things difficult to read in some cases. >> > >> > I'm used to the Lucene style, spaces instead of tabs, with two space >> > indents, as embodied in >> > http://people.apache.org/~rmuir/Eclipse-Lucene-Codestyle.xml >> > >> > Are there styles others prefer? >> > >> > I also want to say upfront that I'm not suggesting a large scale code >> > reformatting to get everything to adhere to any one style at once. I'm >> > simply curious whether there is a style contributors should adhere to >> > going forward, with indentation being fixed as needed along with other >> > changes. >> > >> > Drew >> > >> > -- Joseph Echeverria Cloudera, Inc. 443.305.9434
