[
https://issues.apache.org/jira/browse/ACCUMULO-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158912#comment-13158912
]
Keith Turner commented on ACCUMULO-14:
--------------------------------------
Jesse,
I took a quick look at the patch. It was hard to see what changes were made to
the tablet server and master to achieve the goals of this ticket. There were
formatting changes, many additions of final, additions of @Override. All of
this noise makes it hard to know what changes where made to these very
important classes. If you think things in the master and tablet should be
marked final, I think that work should be done in a separate ticket w/ separate
patches. If you are you using eclipse, are you using formatter mentioned at
http://incubator.apache.org/accumulo/source.html? Would it be possible to
submit a patch that did not have so many extraneous changes? Or point out what
the critical change to the master and tablet server were?
> Transition from fulll Accumulo mocking
> --------------------------------------
>
> Key: ACCUMULO-14
> URL: https://issues.apache.org/jira/browse/ACCUMULO-14
> Project: Accumulo
> Issue Type: Improvement
> Components: client
> Reporter: Jesse Yates
> Fix For: 1.5.0
>
> Attachments: java_ACCUMULO-14-start.patch
>
>
> Original discussion present
> here:http://mail-archives.apache.org/mod_mbox/incubator-accumulo-dev/201110.mbox/%3CCAGUtCHrN3p-7C8Uz7eT0Ze4L0ORzDj1f-x-JWdyrLc=Kx=o...@mail.gmail.com%3E
> Jesse Yates: "Maintaining a real instance and a mock instance ends up
> creating a lot of extra work for dev's by ensuring that there impls are kept
> synchronized....[using a real] instance of Accumulo running on the local file
> system. This would mean less work in the long run to maintain a separate
> instance and better testing for users and new features."
> Keith Turner: "its very fast to create a mock instance which means that unit
> test run very quickly...[and] its all in process which is useful for
> debugging...making mock leverage more of the actual accumulo code, but
> possibly keep it in process for speed and debugging."
> This ticket is to track the discussion and development of a less mocked test
> instance of accumulo, that relies more heavily on the actual implementation,
> rather than parallel mocking features.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
