[
https://issues.apache.org/jira/browse/ACCUMULO-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158929#comment-13158929
]
Jesse Yates commented on ACCUMULO-14:
-------------------------------------
Sorry, that was the 'save actions' in eclipse making haphazard changes. But,
yeah, I'm using the accumulo formatter (though apparently a lot of this was
some crazy line wrapping that is really making it gross).
As far as changes to the TS and Master, I just added a new constructor that
doesn't do argument parsing, but instead gets them passed in in a more DI
oriented style (which also makes testing way easier).
I also made a couple changes to the initalization steps in each of those as
well, essentially allowing booleans to be passed in to determine if the system
should wait for ZK and the DFS to be ready; in the local version they are
assumed to be ready, but the default is to wait (the string parsing version).
As far as final, its really just better coding practice to make stuff like that
final unless you have a reason not to, and since no functionality gets broken,
I don't see a why that would be an issue updating them simultaneously.
I'll look into getting more 'clean' version of the patch up soon.
> Transition from full Accumulo mocking
> -------------------------------------
>
> Key: ACCUMULO-14
> URL: https://issues.apache.org/jira/browse/ACCUMULO-14
> Project: Accumulo
> Issue Type: Improvement
> Components: client
> Reporter: Jesse Yates
> Fix For: 1.5.0
>
> Attachments: java_ACCUMULO-14-start.patch
>
>
> Original discussion present
> here:http://mail-archives.apache.org/mod_mbox/incubator-accumulo-dev/201110.mbox/%3CCAGUtCHrN3p-7C8Uz7eT0Ze4L0ORzDj1f-x-JWdyrLc=Kx=o...@mail.gmail.com%3E
> Jesse Yates: "Maintaining a real instance and a mock instance ends up
> creating a lot of extra work for dev's by ensuring that there impls are kept
> synchronized....[using a real] instance of Accumulo running on the local file
> system. This would mean less work in the long run to maintain a separate
> instance and better testing for users and new features."
> Keith Turner: "its very fast to create a mock instance which means that unit
> test run very quickly...[and] its all in process which is useful for
> debugging...making mock leverage more of the actual accumulo code, but
> possibly keep it in process for speed and debugging."
> This ticket is to track the discussion and development of a less mocked test
> instance of accumulo, that relies more heavily on the actual implementation,
> rather than parallel mocking features.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
