[ 
https://issues.apache.org/jira/browse/ACCUMULO-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221325#comment-13221325
 ] 

John Vines commented on ACCUMULO-407:
-------------------------------------

Found some issues-
+    String propertyLogConfig = String.format("%s/conf/log4j.properties", 
System.getenv("ACCUMULO_HOME"), application);
+    if (new File(logConfig).exists()) {
+       PropertyConfigurator.configureAndWatch(propertyLogConfig, 5000);
line 1 should not have the application argument
line 2 should be new File propertyLogConfig


To put aside these minor foibles, there are a few questions we need to ask 
ourselves in this implementation.
1. Do we want to be watching both the *_logger.xml AND the log4j.properties?
2. Do we want to provide a mechanism to pick up the introduction of an 
application specific logger.xml file after start up?
3. Do we want to continue to have, by default, 2 different logs for each 
application, or can we just have 1?



As for me,
1. Not if we don't have to. I believe the log4j.properties is only used as a 
default until we start watching the *_logger.xml.
2. Not for 1.4, but definitely in the future.
3. Unsure, but not for 1.4
                
> Look into on the fly log4j configuration
> ----------------------------------------
>
>                 Key: ACCUMULO-407
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-407
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: John Vines
>            Assignee: Josh Elser
>             Fix For: 1.4.0
>
>         Attachments: ACCUMULO-407-auto-reload-log4j.patch
>
>
> For long running systems, logs may not want to be kept at the debug level 
> 24/7.  But there may be times where a single long query may be want to looked 
> into without cycling the entire systems. We think it may be possible to make 
> log4j configurable on fly, so lets start by looking into how difficult it 
> will be.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to