[
https://issues.apache.org/jira/browse/ACE-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072313#comment-13072313
]
Marcel Offermans commented on ACE-159:
--------------------------------------
@1: the OSGi specification does not require you to register interfaces for
services, they can be implementations as well (you can argue if that's good
practice, but the spec allows it)
@2: true
@3: true, to be fair, this implementation predates both
Good idea if you ask me, it aligns our implementation with the other ones
(allowing us to even ditch our implementation in the future: less code = less
bugs). If you could supply a patch that would be great.
> Register servlets under objectClass javax.servlet.Servlet instead of
> javax.servlet.http.HttpServlet
> ---------------------------------------------------------------------------------------------------
>
> Key: ACE-159
> URL: https://issues.apache.org/jira/browse/ACE-159
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Bram de Kruijff
>
> ACE registers its servlets whiteboard style under
> objectClass=javax.servlet.http.HttpServlet. The custom whiteboard
> implementation HttpListener bridges them to available Http services.
> 1) I think strictly speaking this is not spec compliant as HttpServlet is not
> an interface?
> 2) It is unnecessarily specific as HttpService#registerServlet accepts
> javax.servlet.Servlet
> 3) It is not (out of the box) portable to Felix HTTP whiteboard or Amdatu
> Dispatcher
> For these reasons I'd suggest switching to objectClass=javax.servlet.Servlet.
> Would be happy to work on a small patch if there is some consensus that this
> is a good idea.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
