Thompson Marzagão wrote:
Hi all,
Do you guys think that maybe the RoleVoter class is way too sensitive? :)
I mean, I had a single space at the end of one of my values for my objectDefinitionSource property definition of the MethodSecurityInterceptor and it took me a while to figure out I had an extra space character there.
Shouldn't the authority comparison code (line 119 in version 1.4 of net.sf.acegisecurity.vote.RoleVoter) trim the SecurityConfig attribute string before the actual comparison?
Just a thought.
Thompson Marzagao
Hi Thompson
Thanks for the suggestion. I ended up implementing the trimming of spaces via the ConfigAttributeEditor, as I can't think of any use cases where a preceding or trailing space would actually be desirable for any configuration attribute (not just role voter). If people do really need this functionality they can use their own PropertyEditor or wire up the ObjectDefinitionSource by a <ref bean="someOtherSource"/>.
A unit test etc is now checked into CVS.
Ben
------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 _______________________________________________ Acegisecurity-developer mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer
