John Lewis wrote:
I'm very interested in your feedback. When you get a chance to take a
look at it all, let me know what you think.
Hi John
Thanks for contributing this code. I just had a quick look, and have a
couple of questions and comments:
- Could you make it compatible with 0.9.0 snapshot? I notice you're
using the <= 0.8.3 context management code, which has been refactored.
- PortletSecurityEnforcementInterceptor and the
PortletSessionContextIntegrationInterceptor do not appear to be in the
ZIP file.
- Am I correct in reading the code that the portlet container performs
the authentication, which yields a String-based username, and your
classes implement a PortletAuthoritiesPopulator (like CAS and X509)? If
so, is there scope to plug in Acegi Security so that the portlet
container can use our AuthenticationManager? Also, is there a default
implementation of PortletAuthoritiesPopulator?
- Are there any unit tests available?
Cheers
Ben
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Home: http://acegisecurity.sourceforge.net
Acegisecurity-developer mailing list
Acegisecurity-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer