Thank you Roman for the review and comments. I created individual github issues for these and all other reviews of acme-subdomains at https://github.com/upros/acme-subdomains/issues
I have committed fixes and closed all bar one of the issues raised below. I will comment on that one inline below. Regards, Owen -----Original Message----- From: Acme <acme-boun...@ietf.org> On Behalf Of Roman Danyliw Sent: Saturday 29 October 2022 22:58 To: acme@ietf.org Subject: [Acme] AD review of draft-ietf-acme-subdomains-04 Hi! I performed an AD review of draft-ietf-acme-subdomains-04. Thanks for this work to extend ACME capability. I have a few comments below, but they aren't significant enough to hold the document. Please address them concurrently with IETF LC. ** Section 2. Editorial. This section takes direct quotes out of RFC8499 but does not put quotation marks around them. However, when text is taken from RFC1034 it has quotes. Recommend consistency. [ofriel] Similar to my feedback on acme-integrations: The quotes or lack of quotes is itself taken directly from the definitions in RFC8499. If you look at RFC8499, the definition of Label is not in quotes; however, the definition of Subdomain starts with a quote as it is pulling in text from RFC1034 into RFC8499. The text in acme-integrations aligns to the character with what is in RFC8499. Does this make sense? _______________________________________________ Acme mailing list Acme@ietf.org https://www.ietf.org/mailman/listinfo/acme
