Hi Giulio,
thanks for your thoughts.
I answer inline below.
On 5/30/13 3:15 AM, Giulio Paci wrote:
> Il 29/05/2013 23:55, Tiago Tresoldi ha scritto:
>> Thank you very much Ulrik, this project is turning into a good long lesson
>> to me -- you fixed in a minute a leak that searched for more than one
>> hour...
>>
>> I vote for keeping the valgrind script.
> I also vote for keeping it.
Great. Let's do that, then.
> Regarding maintainance scripts, I have two questions/proposals:
> 1) why not moving autogen.sh, rmfiles.sh and valgrind.sh in a maintainance/
> directory?
I would actually advocate keeping them in the root directory for the
following reasons:
a) autogen.sh is traditionally placed in the root directory. I have
seen it in lots of packages, and always in the root of the sources.
b) rmfiles.sh could be moved, but it is a script which is run
frequently, and it is easier (IMHO) to run "./rm" + tab rater than
"./maint" + tab + "rm" + tab :-).
c) That would leave valgrind.sh as the only script to be moved. As
William of Ockham has famously said, "do not multiply categories beyond
necessity". That means, in this case, I think we should postpone adding
another directory (with another Makefile.am) until we have more scripts
that actually need to go there.
What do you both think? I am open to arguments to the contrary :-).
> 2) regarding rmfiles.sh: why not making use of "make distclean" in it, so
> that we can also check that the clean and distclean target are working
> properly? If it is ok with
> you, I can upload an updated version of this script.
I hadn't actually thought about that, but it is true: I always run "make
distclean" before I run rmfiles.sh. The rmfiles.sh script is really not
useful before a make distclean, only after it.
OTOH, "make distclean" should only be run from rmfiles.sh if there
actually is a Makefile in the root directory, i.e., if the
user/developer has not already run make distclean.
So, if you would like to put in something like
if test -f Makefile; then
make distclean;
fi
at the top of rmfiles.sh, please go ahead. (Note that I am not an
expert on /bin/sh scripting, so the above may not work :-) ).
On a meta-note: This is the first Open Source project in which I
participate as a an active co-developer rather than being either: a) the
sole developer or b) a "passive" guidance-factor. I am really enjoying
the interaction, and I wish to thank you both.
On a related meta-note: I am also enjoying how you two are pulling in
the good direction of consensus on the mailinglist before decisions are
made. I must confess that, having been the sole developer on my Open
Source projects for 12 years, I do find it a good and worthwhile
exercise to reach consensus, but I must exercise some restraint in not
just developing rather than seeking consensus before developing. Thank
you for your patience -- I promise to learn to communicate rather than
just decide in isolation.
Best,
Ulrik
------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
acopost-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/acopost-devel
