http://bugzilla.kernel.org/show_bug.cgi?id=8286
------- Additional Comments From [EMAIL PROTECTED] 2007-04-30 14:09 -------
You're mixing up various issues here ...
- If PNP nodes don't exist, then just fall back into a legacy mode,
possibly looking pretty much like what you've got now. But when
they do exist, what you're doing is "unclean" from the driver model
perspective: don't device_add(), especially when you've been handed
an appropriate node already! (In fact, the i8042 stack seems to like
creating five nodes where two should suffice... only one AUX present.)
- The ACPI nodes ... I'd suggest you don't worry about those (at least
not yet!); they should eventually not duplicate the PNP nodes.
- Wakeup for i8042 has two aspects.
* One is device_may_wakeup(), a driver input; once the extra device
nodes get sorted out, that will just work ... at least for ACPI.
That's mostly a platform setup issue, other than the way userspace
can overide the "wakeup enabled by default" setting.
* The other is the driver awareness, and somewhere in the i8042
stack will need to be a call_platform_enable_wakeup() call on
the suspend path when it may_wakeup(). (Then undoing it on the
resume path.)
- Why doesn't PNPACPI enable wakeup automatically? I can't answer
for the "old model". But the upcoming patches *do* enable it
automatically. Thing is, the driver needs to check whether user
space has disabled it -- i.e. call device_may_wakeup() -- then
set things up accordingly.
In the general case, drivers need to do a few special things if
they're going to be wakeup event sources. It's possible that
i8042 is an exception, and doesn't have much to do except call
the platform hook ... I wouldn't know that.
On embedded platforms it's more likely that a serio suspend()
method would enable_irq_wake() if it may_wakeup() and its clock
can stay enabled, otherwise clk_disable(). (Though I think that
i8042 clones would mostly just do the irq_wake stuff.)
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
acpi-bugzilla mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
