http://bugzilla.kernel.org/show_bug.cgi?id=9277
------- Comment #10 from [EMAIL PROTECTED] 2007-12-21 08:30 ------- (In reply to comment #5) > Created an attachment (id=14114) --> (http://bugzilla.kernel.org/attachment.cgi?id=14114&action=view) [details] > video brightness control fixup > > Hi, Danny, > Any comment on this patch? :) It seems to work fine. Just two comments: - The value "2" in the validation loop deserves a small comment IMO - it's not intuitive that the first two values in the list are default values ;) - The brightness list returned by _BCL is not guaranteed to be sorted by values (at least I couldn't find an order requirement in the spec), which your code assumes. I don't know how relevant this is, but we should keep this in mind. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
