http://bugzilla.kernel.org/show_bug.cgi?id=6217





------- Comment #29 from [EMAIL PROTECTED]  2008-06-24 19:01 -------
re: patch in comment #28

scripts/checkpatch.pl
ERROR: trailing whitespace
#41: FILE: drivers/acpi/events/evgpe.c:281:
+  $

ERROR: code indent should use tabs where possible
#42: FILE: drivers/acpi/events/evgpe.c:282:
+ ^I/*$

ERROR: code indent should use tabs where possible
#43: FILE: drivers/acpi/events/evgpe.c:283:
+ ^I * Even if we don't know the GPE type, make sure that we always$

ERROR: code indent should use tabs where possible
#44: FILE: drivers/acpi/events/evgpe.c:284:
+ ^I * disable it. low_disable_gpe will just clear the enable bit for this$

ERROR: code indent should use tabs where possible
#45: FILE: drivers/acpi/events/evgpe.c:285:
+ ^I * GPE and write it. It will not write out the current GPE enable mask,$

WARNING: line over 80 characters
#46: FILE: drivers/acpi/events/evgpe.c:286:
+        * since this may inadvertently enable GPEs too early, if a rogue GPE
has

ERROR: code indent should use tabs where possible
#46: FILE: drivers/acpi/events/evgpe.c:286:
+ ^I * since this may inadvertently enable GPEs too early, if a rogue GPE has$

ERROR: code indent should use tabs where possible
#47: FILE: drivers/acpi/events/evgpe.c:287:
+ ^I * come in during ACPICA initialization - possibly as a result of AML or$

ERROR: code indent should use tabs where possible
#48: FILE: drivers/acpi/events/evgpe.c:288:
+ ^I * other code that has enabled the GPE.$

ERROR: code indent should use tabs where possible
#49: FILE: drivers/acpi/events/evgpe.c:289:
+ ^I */$

ERROR: code indent should use tabs where possible
#50: FILE: drivers/acpi/events/evgpe.c:290:
+ ^Istatus = acpi_hw_low_disable_gpe(gpe_event_info);$

ERROR: code indent should use tabs where possible
#51: FILE: drivers/acpi/events/evgpe.c:291:
+ ^Ireturn_ACPI_STATUS(status);$

WARNING: braces {} are not necessary for single statement blocks
#82: FILE: drivers/acpi/hardware/hwgpe.c:77:
+       if (!gpe_register_info) {
+               return (AE_NOT_EXIST);
+       }

ERROR: return is not a function, parentheses are not required
#83: FILE: drivers/acpi/hardware/hwgpe.c:78:
+               return (AE_NOT_EXIST);

WARNING: braces {} are not necessary for single statement blocks
#90: FILE: drivers/acpi/hardware/hwgpe.c:85:
+       if (ACPI_FAILURE(status)) {
+               return (status);
+       }

ERROR: return is not a function, parentheses are not required
#91: FILE: drivers/acpi/hardware/hwgpe.c:86:
+               return (status);

ERROR: return is not a function, parentheses are not required
#106: FILE: drivers/acpi/hardware/hwgpe.c:101:
+       return (status);

ERROR: "foo * bar" should be "foo *bar"
#119: FILE: drivers/acpi/hardware/hwgpe.c:119:
+acpi_hw_write_gpe_enable_reg(struct acpi_gpe_event_info * gpe_event_info)

total: 15 errors, 3 warnings, 103 lines checked


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to