http://bugzilla.kernel.org/show_bug.cgi?id=11000
------- Comment #21 from [EMAIL PROTECTED] 2008-07-05 00:55 ------- Created an attachment (id=16742) --> (http://bugzilla.kernel.org/attachment.cgi?id=16742&action=view) Patch adds a flood protector to kacpid/kacpi_notify queues This is the workqueue flood protector I proposed earlier. This is my first submission of code to the Linux kernel, so please bear with and inform me of any incorrect spinlocks, poorly formatted code, etc. in my patch :) It now has a /proc/acpi/flood directory for options and help, but it lacks boot command line configuration options (e.g. acpi.flood=on acpi.flood.start_wait_time=10000). This can serve as a generic quick fix to any instances of kacpid and/or kacpi_notify spinning, but I'd think users should still file bug reports if they have to enable this. I added a copyright signature for myself at the top of osl.c (where the vast majority of the flood protector code resides). Is this correct protocol? I did test your patch series, and it does indeed seem to clear up all the problems I've mentioned here. I did remember to include the thermal sanity patch I posted earlier, so /proc/thermal_zone/THRM was there. The kacpi_notify spinning problem is completely gone, and I can echo 0 and 3 to /proc/fan/FAN1/state to turn the fan up and down respectively (rather than it being stuck at down). I can't force the acpi.power_nocheck option off with the command line, and this appears to be because my machine type is listed under power_nocheck_dmi_table and set with dmi_check_system(power_nocheck_dmi_table); . To finish up testing on my flood protector, I commented out that line in my working code (but the dmesg's I will attach as well as this patch will not reflect this). I'm recompiling the kernel to get rid of any stray printk traces and to make sure all the patches posted so far work with the 2.6.26-rc8 kernel. I'll post the dmesg before and after suspend pretty soon after that finishes (the flood protector will probably not affect things since there won't be flooding, but will post a warning if there is flooding). -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ acpi-bugzilla mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
