https://bugzilla.kernel.org/show_bug.cgi?id=25072
Indan <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #11 from Indan <[email protected]> 2011-02-17 01:13:15 --- (Lukas, you didn't get a notification mail because you weren't on the CC list. I added you back.) Okay, thanks for te feedback Lukas. All in all it seems that the LBPC register value got stored and restored by your laptop. My patch doesn't touch that one, so if it got lowered by the old code it would stay low, that's why rebooting with max brightness "fixed it". The bad thing about this is that if people switch to a good kernel they can still have a messed up backlight. :-( No idea about X setting the brightness to 0, might be a freak side-effect of the buggy code, I don't know why my patch fixes that. --- Alex, that patch doesn't look totally correct. It always sets brightness to the maximum at bootup, for one thing, and the rest seems a mix of Chris' patch and partially reverting another of his patches, right? In the end it boils down to reverting the introduction of the i915_read_blc_pwm_ctl() helper function, but I don't see how that can ever make a difference because 'val' can't ever be zero, as far as I know. The only other real change is the addition of: @@ -267,6 +235,9 @@ void intel_panel_enable_backlight(struct drm_device *dev) { struct drm_i915_private *dev_priv = dev->dev_private; + if (dev_priv->backlight_enabled) + return; + But calling this multiple times when the panel is already enabled should be fine. So see bug 23472, I think you got as far as me without my patch, which means it mostly works, but not for the lowest or highest brightness after boot, suspend or screen blanking. Anyway, this bug should be closed as duplicate of bug 23472. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ acpi-bugzilla mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
