https://bugzilla.kernel.org/show_bug.cgi?id=43228
Peter <lekenst...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lekenst...@gmail.com
--- Comment #1 from Peter <lekenst...@gmail.com> 2012-05-11 15:37:17 ---
There are three commits between rc1 and rc6.
Commit 37239978778806ecba54da60676abb46870acebb removes setting the
valid flag when _PSx is found (where x is a state between 0 and 3).
3ebc81b8937d2bc1d0d0064bed29434dfce490aa is not particularly interesting, it
updates the validation for a state (states greater than D3cold are nonsense)
and would add a check that is removed in the next commit.
Part of the next commit 1cc0c998fdf2cb665d625fb565a0d6db5c81c639 diff
(indentation removed for formatting)
- /* State is valid if we have some power control */
- if (ps->resources.count || ps->flags.explicit_set)
+ /*
+ * State is valid if there are means to put the device into it.
+ * D3hot is only valid if _PR3 present.
+ */
+ if (ps->resources.count ||
+ (ps->flags.explicit_set && i < ACPI_STATE_D3_HOT))
I think that the last line is wrong. Shouldn't it be
"i <= ACPI_STATE_D3_HOT"? (note the equality sign). With the current
code, D3cold is ignored (okay I guess), but D3hot is ignored too
for all devices without a power resource for the given state. Can you
try changing "<" to "<=" as described?
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
