https://bugzilla.kernel.org/show_bug.cgi?id=43284
katabami <katab...@lavabit.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83791|0 |1
is obsolete| |
--- Comment #18 from katabami <katab...@lavabit.com> 2012-10-19 06:57:55 ---
Created an attachment (id=83951)
--> (https://bugzilla.kernel.org/attachment.cgi?id=83951)
New patch, following Documentation/SubmittingPatches
Thank you very much, Thomas. The new patch doesn't distinguish 6715b and 6715s.
Both use the same chipset, RS690T for northbridge and SB600 for southbridge,
according to HP's documentation[1] and (seemingly) from the above lspci output.
(I don't know what's chipset.)
If it's better to write the chipset info into the code, I'll rewrite. In
arch/x86/kernel/early-quirks.c there's a fix for SB600, so this bug may matter
non-HP PCs, too.
Indent is fixed too. It looks natural now. Recompiled and seems to work.
The patch is produced by git-format-patch, and I think I followed
/usr/src/linux/Documentation/SubmittingPatches. Used checkpath.pl.
For recording, let me be precise on the symptom of this bug, slowing down, is
separate from cpu frequency fixing. Even if you limit it to the lowest
frequency from the beginning, it slows down much.
BTW two extra proposals:
1. Style: other two quirk supporter, static int thermal_tzp, and thermal_psv,
have strings broken into two lines. If you want, I can create another patch to
combine them into one.
2. Removal of redundant code: In 2008, Andreas Herrmann proposed[2] to remove
some quirks for 6715b and other HP PCs in arch/x86/kernel/acpi/boot.c. These
codes became redundant because of new codes in arch/x86/kernel/early-quirks.c,
but doesn't harm, because it simply detects twice. Andreas later said "let's
keep it for the next version", and probably they forgot. (The bug they'd fixed
also was reported by Jason Vas Dias.[3] Thanks Jason indeed!) I hit upon it
yesterday.
If you want, I'll try to update and resend Andreas' code.
I tested in the opposite way - My 6715s was not detected by the supposedly
redundant code, so I added 6715s there, instead of removing the entire code,
and it doesn't change the situation. So these codes must in fact be useless.
Best regards.
[1]
p. 1 of:
HP Compaq 6715b and 6715s Notebook PC, HP Compaq 6710b and 6710s Notebook PC
http://h10032.www1.hp.com/ctg/Manual/c02834030.pdf
(6710's chipsets are different from 6715's.)
[2]
http://lkml.indiana.edu/hypermail/linux/kernel/0810.2/0126.html
[3]
https://bugzilla.kernel.org/show_bug.cgi?id=11516
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
