----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110765/#review33564 -----------------------------------------------------------
Ship it! looks good. might be nice to also have a test for re-activating an account after it is disabled. but this can already go in. some comments below that can make future test writing a little simpler. server/test/accounts.js <http://git.reviewboard.kde.org/r/110765/#comment24804> to simplify this, you can use queryString: '/bodega/v1/json/register/confirm?' + queryString.stringify(userInfo); (where queryString is declared with the other requires as: var queryString = require('querystring'); - Aaron J. Seigo On June 1, 2013, 12:06 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110765/ > ----------------------------------------------------------- > > (Updated June 1, 2013, 12:06 p.m.) > > > Review request for Bodega. > > > Description > ------- > > With this test we are creating a new user, we are activating that user and we > are disable that user. > > > This addresses bug 320544. > http://bugs.kde.org/show_bug.cgi?id=320544 > > > Diffs > ----- > > server/test/accounts.js PRE-CREATION > server/test/support/http.js b9e5cb3 > > Diff: http://git.reviewboard.kde.org/r/110765/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active
