----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110892/#review34296 -----------------------------------------------------------
server/lib/db/purchaseAsset.js <http://git.reviewboard.kde.org/r/110892/#comment25180> this could be a switch statement .. server/lib/db/purchaseAsset.js <http://git.reviewboard.kde.org/r/110892/#comment25181> just return a Database error in this case; since the user is authenticated we know they exist, so the only way we can get back error code 2 is if the database has failed us. server/lib/errors.js <http://git.reviewboard.kde.org/r/110892/#comment25179> this should be put up with the generic errors as this should also get used in the assetinfo.js file. perhaps put it after InvalidEmailAddress with id 1001 server/lib/errors.js <http://git.reviewboard.kde.org/r/110892/#comment25178> since the user is authenticated, this can't happen server/lib/errors.js <http://git.reviewboard.kde.org/r/110892/#comment25177> this is already covered by "PurchaseNotEnoughPoints": 26 - Aaron J. Seigo On June 13, 2013, 1:35 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110892/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 1:35 p.m.) > > > Review request for Bodega. > > > Description > ------- > > Hello, > > With this patch, we will be able to know more information about why an asset > has being failed to purchased. > > > Diffs > ----- > > server/lib/db/purchaseAsset.js b01a652 > server/lib/errors.js 27fe443 > > Diff: http://git.reviewboard.kde.org/r/110892/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active