----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111162/#review36494 -----------------------------------------------------------
Ship it! fix up the two comments below and then push server/test/purchase.js <http://git.reviewboard.kde.org/r/111162/#comment26931> should not be using getHtml if it is not expecting html. either pass in stream as you noted, or add a new getStream to utils.js that is like getHtml server/test/support/utils.js <http://git.reviewboard.kde.org/r/111162/#comment26930> this is wrong :) - Aaron J. Seigo On July 25, 2013, 1:21 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111162/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 1:21 p.m.) > > > Review request for Bodega. > > > Description > ------- > > The test should check for the following: > > * purchasing an asset the account does not have enough points for > * purchase an asset the account does have enough points for > * downloading the asset that was purchased > * downloading an asset that costs points that was not purchased > * downloading a free asset > > Things that are missing: > > * confirm points are properly distributed between store and asset owners > * confirm download records are correct > > > How can we verify the two above which are missing from the test? > > > This addresses bug 320545. > http://bugs.kde.org/show_bug.cgi?id=320545 > > > Diffs > ----- > > server/lib/db/purchaseAsset.js 2613615 > server/test/purchase.js PRE-CREATION > server/test/support/utils.js f4d5313 > > Diff: http://git.reviewboard.kde.org/r/111162/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Active mailing list [email protected] https://mail.kde.org/mailman/listinfo/active
