----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111401/#review36531 -----------------------------------------------------------
Ship it! One small issue below, fix that and then push. sql/testdata.sql <http://git.reviewboard.kde.org/r/111401/#comment26963> because you are inserting new values to these tables, you also need to clear the tables first (so `make test_data` produces the *same* results each time) this should be done earlier in the file where other tables are cleared with delete statements. - Aaron J. Seigo On July 26, 2013, 10:12 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111401/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 10:12 a.m.) > > > Review request for Bodega. > > > Description > ------- > > This patch implements the ratings feature in the bodega-server. > > I have also attached a screenshot of the apidocs. > > > Diffs > ----- > > server/bodegaDbHelper ba740cb > server/doc/bodega.json 59c14e3 > server/lib/bodegadb.js 3be8d81 > server/lib/db/ratings.js PRE-CREATION > server/lib/errors.js 356d7c4 > server/routes.js 726fc80 > server/test/ratings.js PRE-CREATION > server/test/support/http.js 84a5fee > sql/core.plsql 7b92784 > sql/ratings.sql PRE-CREATION > sql/testdata.sql dd15d57 > > Diff: http://git.reviewboard.kde.org/r/111401/diff/ > > > Testing > ------- > > ./node_modules/.bin/mocha test/ratings.js --reporter spec > WARNING: Setting up server with no ssl! > Bodega server listening on localhost:3000 in devel mode > > > Ratings > needs to authorize first > ? authorize correctly. (107ms) > List Attributes > ? it should fail because the asset is invalid > ? it should succeed > Remove asset rate > ? it should fail because the asset is invalid > ? it should succeed > Asset Ratings > ? it should fail because the asset is invalid > ? it should succeed > ? it should be empty because there are no ratings for the asset > Participant > ? it should succeed > ? it should have no ratings > Add asset rate > ? it should fail because the asset is invalid > ? it should succeed > > > 12 passing (219 ms) > > > File Attachments > ---------------- > > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/07/05/bodega-ratings-apidocs.png > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Active mailing list [email protected] https://mail.kde.org/mailman/listinfo/active
