> On Sept. 3, 2013, 11:40 a.m., Aaron J. Seigo wrote: > > server/lib/db/assetinfo.js, lines 36-39 > > <http://git.reviewboard.kde.org/r/112478/diff/6/?file=186751#file186751line36> > > > > instead of checking this each time, we can simply require the > > configuration to be correct. > > Giorgos Tsiapaliokas wrote: > How are we going to implement it? > One approach could be to raise an exception in app.js if > app.config.service.discourse.externalUrl doesn't end with '/'. > > Any other ideas?
there is no need for any check at all. the person who sets up the server needs to make sure that discourse.externalUrl ends in a slash. this is not user-provided input but something from the config file. we can assume that the values there are correct. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112478/#review39253 ----------------------------------------------------------- On Sept. 3, 2013, 11:38 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112478/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 11:38 a.m.) > > > Review request for Bodega. > > > Description > ------- > > Hello, > > this patch maps the assets with the links from the discourse categories. > The json from asset/:assetId will contain a property named "discourseLink" > with the > appropriate link > > > Diffs > ----- > > server/config.json.sample 1b5ea7f > server/lib/db/assetinfo.js b52af3b > sql/discourse.plsql 7d108a4 > > Diff: http://git.reviewboard.kde.org/r/112478/diff/ > > > Testing > ------- > > the output from asset/8 > > { > "authStatus": true, > "device": "KDE-1", > "store": "KDE-1", > "points": 9925, > "success": true, > "asset": { > "id": 8, > "license": "GPL", > "partnerId": 1002, > "version": "0.1", > "created": "2013-09-02T17:50:10.386Z", > "filename": "org.kde.poker1.plasmoid", > "image": "poker1.png", > "name": "Poker1", > "description": "Poker 1", > "points": 15, > "canDownload": true, > "tags": [ > { > "grouping": "name_p" > }, > { > "mimetype": "application/x-plasma" > }, > { > "contentrating": "Early Childhood" > }, > { > "assetType": "game" > }, > { > "category": "Card Game" > } > ], > "discourseLink": "localhost:3000/category/Forum%20for%20Poker1" > } > } > > > File Attachments > ---------------- > > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/discourse_forum.png > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Active mailing list [email protected] https://mail.kde.org/mailman/listinfo/active
