[ https://issues.apache.org/activemq/browse/AMQ-608?page=all ]
     
Kevin Yaussy reopened AMQ-608:
------------------------------


Hiram,

Very sorry that I did not look at the 4.0.1 source until the last couple days.  
I'd like to submit patches this time (I don't have svn, but I will attach 
regular "diff -u" patches).

For DemandForwardingBridgeSupport, there was just one change that was left out.

For FailoverTransport, it looks like things got changed around in kind of the 
opposite direction I was looking for.  For me, I really don't care about the 
message "waiting for transport to reconnect" that comes out once a second 
during a send.  Seemed like that one was less meaningful than the message 
"waiting " + reconnectDelay + " ms before attempting connection".  That's the 
one I would prefer to be debug, whereas the other message would be trace.

Then, additionally, I am including a logging patch for InactivityMonitor.java.  
I would like to be able to see when readCheck is going to throw 
InactivityIOException and also show the connection info.  I also don't care 
about the other debug stuff.  So, I changed the readCheck log message to be 
info and added the toString to the message.  Alternatively, I have a second 
patch that does the same thing, but turns all current debug into trace, and 
just the readCheck message to debug.  Either way is good for me.  The issue 
here is that the Broker won't show this InactivityIOException, and I'd like to 
see it (just not all the other debug stuff).  The client-side, I think, is OK 
since now the TransportListener "interrupted" / "resumed" works.  But the 
broker is silent about this and I would like to see it.

Thanks.


> Change logging level of some DemandForwardingBridge log messages.
> -----------------------------------------------------------------
>
>          Key: AMQ-608
>          URL: https://issues.apache.org/activemq/browse/AMQ-608
>      Project: ActiveMQ
>         Type: Improvement

>   Components: Broker
>     Versions: 4.0
>     Reporter: Kevin Yaussy
>     Assignee: Hiram Chirino
>      Fix For: 4.0.1, 4.1
>  Attachments: DemandForwardingBridge.java, 
> DemandForwardingBridgeSupport.java, FailoverTransport.java, 
> FailoverTransport.java
>
>
> In DemandForwardingBridge, I'd like to be able to see subscription messages 
> (and unsubscription messages), but not "bridging" messages.  Both classes of 
> log messages are log.trace.  Seems like the "bridging" messages should remain 
> trace, as you would want to look at that when you are doing pretty detailed 
> debugging.  However, I'd like to see subscribe/unsubscribe messages all the 
> time.  If those could be either info or debug, that would allow me to turn 
> those on separately.  I realize that I can see what is currently subscribed 
> via the JMX console.  However, seeing the subscribe/unsubscribe messages will 
> allow diagnostics over time - who subscribed when type of questions.
> Mainly, I'm referring to messages logged as trace in:
> DemandForwardingBridge.serviceRemoteConsumerAdvisory
> DemandForwardingBridge.removeDemandSubscription

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to