Hi Michael,

a running rails 3 unit test system is one of the big missing features
for rails 3 fork, which implies that there currently are no guidelines
for updating test cases. :-(

A general guide line for pull requests... I do not think you have to
do anything special.
fork preferrable latest version.
use that fork to add your new feature or fix a bug
send a pull request.

In case you find a bug it would be great if you could add it to github
issue tracker.

--
Volker


On Apr 17, 2:05 am, Michael Latta <[email protected]> wrote:
> I have another case that appears to fail for association subforms:
>
> 1) The association is :dependent => :destroy
> 2) The destroy on the child record fails (returns false, and sets an error on 
> the record).
>
> The update completes, does not report any errors to the user, but the record 
> is neither destroyed or removed from the association.  When the user opens 
> the record again the "deleted" subform is back.
>
> I will be fixing this in my fork of the rails 3 fork.  I expect to add 
> testing on association updates to detect this and some other failing cases 
> and report errors accordingly.  If there are any other issues to be addressed 
> at the same time of the same nature I would welcome input so the update 
> improvements can cover as many cases as possible.  I would also welcome some 
> pointers to the test cases being used for AS that deal with updates and any 
> guidelines on updating test cases for pull requests.
>
> Michael

-- 
You received this message because you are subscribed to the Google Groups 
"ActiveScaffold : Ruby on Rails plugin" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/activescaffold?hl=en.

Reply via email to